CLN: Removed outdated comment #30782
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datapythonista
approved these changes
Jan 7, 2020
jbrockmendel
reviewed
Jan 7, 2020
| c = Categorical(idx) | ||
|
|
||
| # TODO(wesm): exceeding 80 characters in the console is not good | ||
| # behavior |
There was a problem hiding this comment.
is this referring to the code or to the string being returned? black only affects the former
There was a problem hiding this comment.
It's about the output.
In [16]: idx = pd.CategoricalIndex(list(string.ascii_letters))
In [17]: [len(x) for x in repr(idx).split('\n')]
Out[17]: [77, 77, 77, 77, 38, 107]
|
Thanks @MomIsBestFriend |
|
@MomIsBestFriend - I don’t think this is referring to black. Think it’s related to #22524 |
|
@alimcmaster1 should it be reverted then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffI think this is a bit outdated, since we are using black and it's doing the work for us, right?
according to git blame, this is 2 years old.